[CharInv] Migrate from deprecations#3885
Merged
imnasnainaec merged 6 commits intomasterfrom Aug 12, 2025
Merged
Conversation
imnasnainaec
added
enhancement
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3885 +/- ##
==========================================
- Coverage 74.12% 74.11% -0.02%
==========================================
Files 288 288
Lines 10620 10615 -5
Branches 1327 1327
==========================================
- Hits 7872 7867 -5
Misses 2362 2362
Partials 386 386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jasonleenaylor
approved these changes
Aug 12, 2025
Contributor
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
Reviewed 7 of 8 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parts of #3180, #3879
Notes for review:
<Grid>with<Grid2>,<Stack>,<div>, or nothing, as fit the design need.CharInvinto child componentCharacterEntryat topNotes for testing:
master(on QA) to make sure appearance is (roughly) the same or (subjectively) improved on all edited componentsCurrently on QA, you have to scroll to the bottom to see the Save/Cancel buttons:
This pr moves the Save/Cancel buttons up next to the "Advanced" option:
This change is